Update github actions versions #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dflook
force-pushed
the
checkout
branch
2 times, most recently
from
c9a8e5e to
80c0a89
Compare
GitHub decided to use nodejs for their github actions, such as checkout/upload-artifact/download-artifact etc. This is problematic when running actions jobs inside containers, as node needs to get in there somehow. The actions runner rams a nodejs runtime into your containers, whether it works there or not. GitHub are threatening to use a newer nodejs runtime, which certainly does NOT work in some of the older python containers. To address this there is a new composite action called 'run-in-container', which tries to approximate the same behaviour as running jobs inside containers, but for a single step. This means that the GitHub provided actions in the job can now run outside the test container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub decided to use nodejs for their github actions, such as checkout/upload-artifact/download-artifact etc. This is problematic when running actions jobs inside containers, as node needs to get in there somehow. The actions runner rams a nodejs runtime into your containers, whether it works there or not.
GitHub are threatening to use a newer nodejs runtime, which certainly does NOT work in some of the older python containers.
To address this there is a new composite action called 'run-in-container', which tries to approximate the same behaviour as running jobs inside containers, but for a single step. This means that the GitHub provided actions in the job can now run outside the container.