Skip to content

Api v2 get global task #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 159 commits into
base: develop
Choose a base branch
from
Open

Api v2 get global task #971

wants to merge 159 commits into from

Conversation

@c8y3
Copy link
Contributor

@c8y3 c8y3 commented Nov 12, 2025 •
edited
Loading

Implementation of GET /api/v2/global-tasks/{identifier}

  • Deprecated GET /global/tasks/<int:cur_id>
  • removed too generic of a method get_or_create from app.models.models
  • split app.models.models some more into app.models.cases, app.models.assets and app.models.customers

This PR goes with the documentation PR#96

Elise17 added 30 commits October 8, 2025 14:04
@Elise17
Started implementation of POST /api/v2/alerts-filters
9a33abf
@Elise17
Fixed analysis check
b7088fd
@Elise17
Added function _load
103ed2c
@Elise17
Deprecated endpoint POST /filters/add in favor of POST /api/v2/alerts…
82bfec6 
…-filters
@Elise17
Added test create alert when filter data is missing
5b1290e
@Elise17
Added test test_create_alert_filter_should_return_filter_type
ea45b99
@Elise17
Added test_create_alert_filter_should_return_filter_name
4c5ddd6
@Elise17
Added test_create_alert_filter_should_return_in_filter_data_alert_title
0a0f63d
@Elise17
Started implementation of GET /api/v2/alerts-filters/{identifier}
af0bf2b
@Elise17
Fixed check analysis
0c911fe
@Elise17
Fixed importation problem
8559ad7
@Elise17
Fixed static analysis
7440b09
@Elise17
Removed user in test
0690eb0
@Elise17
Added test_get_alert_filter_should_return_filter_name
1129b73
@Elise17
Deprecated endpoint GET /filters/{identifier}
97a89e5
@Elise17
Added test_get_alert_filter_should_return_404
622b46a
@Elise17
Added test_get_alert_filter_should_return_404_when_user_has_not_creat…
9a1fffd 
…ed_alert_filter
@Elise17
Fixed static analysis
e4b4998
@Elise17
Started implementation of PUT /api/v2/alerts-filters/{identifier}
69e38c8
@Elise17
Fixed static analysis
ec809ef
@Elise17
Added test_update_alert_filter_should_return_filter_name
f438d3b
@Elise17
Added test_update_alert_filter_should_return_filter_description
930e94c
@Elise17
Added test_update_alert_filter_should_return_filter_type
120bed5
@Elise17
Added test_update_alert_filter_should_return_filter_data_alert_title
48c0957
@Elise17
Added test_update_alert_filter_should_return_404_when_alert_filter_is…
657d441 
…_not_found
@Elise17
Removed identifietr in test_update_alert_filter_should_return_404_whe…
1008f29 
…n_alert_filter_is_not_found
@Elise17
Deprecated endpoint POST /filters/update/{identifier}
78234ef
@Elise17
Started implmentation of endpoint DELETE /api/v2/alerts-filters/{iden…
eb541cb 
…tifier}
@Elise17
Added test_delete_alert_filter_should_return_404_when_alert_not_found
745739c
@Elise17
test_get_alert_filter_should_return_404_after_delete_alert_filter
74bf4ea
c8y3 added 25 commits November 7, 2025 11:21
@c8y3
Added a FIXME
5544829
@c8y3
Removed unnecessary return
8fa3305
@c8y3
Added import constraint: Do not import the persistence layer from the…
c69dcf5 
… models
@c8y3
Deprecated POST /global/tasks/add
1daa99c
@c8y3
Removed an import app
7a1b747
@c8y3
Removed an import app
c345e41
@c8y3
Removed an import app
5c474c1
@c8y3
Started GET /api/v2/global-tasks/{identifier}
d4346fd
@c8y3
Removed unnecessary return
b314c45
@c8y3
Removed seemingly unnecessary method
ed4d0d5
@c8y3
Fixed ruff warning
149d3c9
@c8y3
Fixed import to Client
3b57d7f
@c8y3
Removed one use of too generic method get_or_create in models
aa735c4
@c8y3
Fixed ruff warning
002d718
@c8y3
Added test to check Analysts group autofollow is set to false
3af00d3
@c8y3
Removed some usages of get_or_create
8e6f5ca
@c8y3
Removed method get_or_create
21c01f4
@c8y3
Moved CaseStatus into app.models.cases
6644e6c
@c8y3
Moved ReviewStatusList into app.models.cases
be4a6c0
@c8y3
Put Client model in its own module
4479bd2
@c8y3
Deprecated GET /global/tasks/<int:cur_id>
63a55b6
@c8y3
Moved CaseAssets out of app.models.models into app.models.assets
b854cda
@c8y3
Moved AnalysisStatus in app.models.assets
50f88d1
@c8y3
Moved CaseClassification into app.models.cases
c846f0e
@c8y3
Fixed ruff warnings
b252df8
@c8y3 c8y3 requested a review from whikernel November 12, 2025 13:30
@c8y3 c8y3 added the enhancement New feature or request label Nov 12, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • api_*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch api_v2_get_global_task

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@c8y3 c8y3 linked an issue Nov 12, 2025 that may be closed by this pull request
API v2 get global task #970
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whikernel whikernel Awaiting requested review from whikernel

Assignees

@whikernel whikernel

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API v2 get global task

4 participants

@c8y3 @whikernel @Elise17