Skip to content

Api v2 update customer #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 97 commits into
base: develop
Choose a base branch
from
Open

Api v2 update customer #961

wants to merge 97 commits into from

Conversation

@c8y3
Copy link
Contributor

@c8y3 c8y3 commented Oct 29, 2025 •
edited
Loading

Implementation of PUT /api/v2/manage/customers/{identifier}

This is accompanied by the documentation PR#91 in iris-doc-src.

Elise17 added 30 commits October 8, 2025 14:04
@Elise17
Started implementation of POST /api/v2/alerts-filters
9a33abf
@Elise17
Fixed analysis check
b7088fd
@Elise17
Added function _load
103ed2c
@Elise17
Deprecated endpoint POST /filters/add in favor of POST /api/v2/alerts…
82bfec6 
…-filters
@Elise17
Added test create alert when filter data is missing
5b1290e
@Elise17
Added test test_create_alert_filter_should_return_filter_type
ea45b99
@Elise17
Added test_create_alert_filter_should_return_filter_name
4c5ddd6
@Elise17
Added test_create_alert_filter_should_return_in_filter_data_alert_title
0a0f63d
@Elise17
Started implementation of GET /api/v2/alerts-filters/{identifier}
af0bf2b
@Elise17
Fixed check analysis
0c911fe
@Elise17
Fixed importation problem
8559ad7
@Elise17
Fixed static analysis
7440b09
@Elise17
Removed user in test
0690eb0
@Elise17
Added test_get_alert_filter_should_return_filter_name
1129b73
@Elise17
Deprecated endpoint GET /filters/{identifier}
97a89e5
@Elise17
Added test_get_alert_filter_should_return_404
622b46a
@Elise17
Added test_get_alert_filter_should_return_404_when_user_has_not_creat…
9a1fffd 
…ed_alert_filter
@Elise17
Fixed static analysis
e4b4998
@Elise17
Started implementation of PUT /api/v2/alerts-filters/{identifier}
69e38c8
@Elise17
Fixed static analysis
ec809ef
@Elise17
Added test_update_alert_filter_should_return_filter_name
f438d3b
@Elise17
Added test_update_alert_filter_should_return_filter_description
930e94c
@Elise17
Added test_update_alert_filter_should_return_filter_type
120bed5
@Elise17
Added test_update_alert_filter_should_return_filter_data_alert_title
48c0957
@Elise17
Added test_update_alert_filter_should_return_404_when_alert_filter_is…
657d441 
…_not_found
@Elise17
Removed identifietr in test_update_alert_filter_should_return_404_whe…
1008f29 
…n_alert_filter_is_not_found
@Elise17
Deprecated endpoint POST /filters/update/{identifier}
78234ef
@Elise17
Started implmentation of endpoint DELETE /api/v2/alerts-filters/{iden…
eb541cb 
…tifier}
@Elise17
Added test_delete_alert_filter_should_return_404_when_alert_not_found
745739c
@Elise17
test_get_alert_filter_should_return_404_after_delete_alert_filter
74bf4ea
c8y3 added 21 commits October 24, 2025 14:12
@c8y3
Fixed and added all ruff B00* rules
86e556b
@c8y3
Set ruff rules FURB142, FURB145 and FURB148 rather than RUF14* (I am …
0329817 
…not sure whether we want RUF140)
@c8y3
Removed PYI rules: we do not seem to use pyi
4070b55
@c8y3
Added dead code check with vulture
535556f
@c8y3
Renamed vulture ignore file so that ruff does not parse it as a pytho…
9cc46da 
…n file
@c8y3
Removed validate_asset_type from vulture ignore list to check it fail…
3fb283a 
…s the build
@c8y3
Removed seemingly dead methods
13bb46c
@c8y3
Commented seemingly dead code which is used by iris-module-interface
e89de9e
@c8y3
Started implementation of PUT /api/v2/manage/customers/{identifier}
e080126
@c8y3
PUT /api/v2/manage/customers/{identifier} should return 400 when anot…
b400f72 
…her customer with the same name exists
@c8y3
Moved database code out of marshables into the persistence layer
e6625f1
@c8y3
Added some ignored files to vulture
39ac885
@c8y3
Improved configuration of vulture somewhat
33a4a4e
@c8y3
Improved configuration of vulture somewhat
de86e58
@c8y3
Improved configuration of vulture somewhat
f25c442
@c8y3
Organized vulture ignore file a bit more
de3b44e
@c8y3
Simplified vulture ignore file somewhat
c4a4881
@c8y3
Deprecated PUT /manage/customers/update/<int:client_id>
97ee448
@c8y3
Removed one occurence of ElementNotFoundException (use ObjectNotFound…
48c1209 
…Exception instead)
@c8y3
Removed unnecessary parameter
ee14b4a
@c8y3
Removed exception ElementNotFoundException
ed60317
@c8y3 c8y3 added the enhancement New feature or request label Oct 29, 2025
@c8y3 c8y3 linked an issue Oct 29, 2025 that may be closed by this pull request
API v2 update customer #956
Open
10 tasks
@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • api_*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch api_v2_put_customer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@c8y3 c8y3 changed the title Api v2 put customer Api v2 update customer Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@whikernel whikernel

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API v2 update customer

4 participants

@c8y3 @whikernel @Elise17