Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #!pwsh shebang from powershell code block #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Jawz84
Copy link

@Jawz84 Jawz84 commented Nov 19, 2020

.NET Interactive Notebooks add this shebang, it needs to be removed to get a nice, clean export.

.NET Interactive Notebooks add this shebang, it needs to be removed to get a nice, clean export.
@dfinke
Copy link
Owner

dfinke commented Nov 19, 2020

Thanks for the PR. Would you be up to adding a Pester test for that?

@Jawz84
Copy link
Author

Jawz84 commented Nov 20, 2020

I added two tests, and improved the implementation a bit. Let me know if you like it this way.

@Jawz84
Copy link
Author

Jawz84 commented Nov 20, 2020

Hmm. Tests pass in the development container, but auto CI seems to fail.
-edit: it was a CRLF vs LF issue, fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants