Skip to content

feat: Support follow mode for 'dfx canister logs'. #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2025
Merged

feat: Support follow mode for 'dfx canister logs'. #4215

merged 5 commits into from
Apr 21, 2025

Conversation

vincent-dfinity
Copy link
Contributor

@vincent-dfinity vincent-dfinity commented Apr 17, 2025 •
edited
Loading

Description

Support follow mode for 'dfx canister logs':

  • --follow to enable the follow mode, which keeps fetching the logs continuously.
  • --interval to set the interval.

Fixes # (issue)

SDK-2069

How Has This Been Tested?

  • Unit test added.
  • Manually tested locally.
  • Cannot find an elegant way to test in the e2e test framework.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vincent-dfinity vincent-dfinity marked this pull request as ready for review April 18, 2025 12:30
@vincent-dfinity vincent-dfinity requested a review from a team as a code owner April 18, 2025 12:30
@vincent-dfinity vincent-dfinity merged commit a026b45 into master Apr 21, 2025
178 checks passed
@vincent-dfinity vincent-dfinity deleted the vincent/SDK-1670 branch April 21, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-dfinity @ericswanson-dfinity