feat!: confirm short freezing threshold #4203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1208,10 +1208,11 @@ You can specify the following options for the `dfx canister update-settings` com | |||
| | `--add-log-viewer <principal>` | Add a principal to the list of log viewers of the canister. Can be specified more than once to add multiple log viewers. If current log visibility is `public` or `controllers`, it will be changed to the custom allowed viewer list. | | |||
| | `-c`, `--compute-allocation <allocation>` | Specifies the canister's compute allocation. This should be a percent in the range [0..100]. | | |||
| | `--confirm-very-long-freezing-threshold` | Freezing thresholds above ~1.5 years require this option as confirmation. | | |||
| | `--confirm-very-short-freezing-threshold` | Freezing thresholds below 1 week require this option as confirmation. | | |||
There was a problem hiding this comment.
I really think we only need one combined --confirm-freezing-threshold for both --confirm-very-long-freezing-threshold and --confirm-very-short-freezing-threshold. I'm fine with adding the new --confirm-very-short-freezing-threshold only for backward compatibility...
vincent-dfinity
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting very short freezing thresholds can be dangerous as it may lead to canisters suddenly getting uninstalled with little warning when cycles run low. This PR introduces the
--confirm-very-short-freezing-thresholdflag when setting freezing thresholds below 1 week / 604_000 seconds.Fixes SDK-2079
How Has This Been Tested?
Added e2e
Checklist: