Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ubuntu #4131

Merged
merged 9 commits into from
Mar 5, 2025
Merged

chore: bump ubuntu #4131

merged 9 commits into from
Mar 5, 2025

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Mar 4, 2025

ubuntu-20.04 runners are getting deprecated: actions/runner-images#11101

@sesi200 sesi200 requested a review from a team as a code owner March 4, 2025 13:49
@ericswanson-dfinity ericswanson-dfinity dismissed their stale review March 4, 2025 23:15

workflows not yet passing

Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe leave an issue to fix the "quirks mode" reply (possibly by tweaking the HTML?) sometime.

sesi200 added a commit to dfinity/candid that referenced this pull request Mar 5, 2025
Our frontend tests found a warning about quirks mode in Firefox in
dfinity/sdk#4131. This removes the need for the
warning
@sesi200 sesi200 merged commit 903f21d into master Mar 5, 2025
296 checks passed
@sesi200 sesi200 deleted the severin/bump-ubuntu branch March 5, 2025 14:24
ggreif pushed a commit that referenced this pull request Mar 6, 2025
ggreif added a commit that referenced this pull request Mar 6, 2025
* chore: update replica version to ebb190bf1da0dba3e486b78c95cf5a3c5542e2f3

* Update CHANGELOG.md

* chore: bump ubuntu (#4131)

* bump `dfx` extension `nns` to 0.5.0

due to test failures

* attempt to fix output mismatch

see #4130 why this is needed

---------

Co-authored-by: ericswanson-dfinity <[email protected]>
Co-authored-by: Severin Siffert <[email protected]>
Co-authored-by: Gabor Greif <[email protected]>
Co-authored-by: Gabor Greif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants