Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: default to PocketIC #4130

Merged
merged 7 commits into from
Mar 5, 2025
Merged

feat!: default to PocketIC #4130

merged 7 commits into from
Mar 5, 2025

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Mar 4, 2025 •
edited by jira bot
Loading

Description

As announced dfx start now runs PocketIC by default.
Running a local replica is still possible with --replica, but this option will be removed in the near future.

Fixes SDK-1989

How Has This Been Tested?

Covered by e2e

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 marked this pull request as ready for review March 5, 2025 13:08
@sesi200 sesi200 requested a review from a team as a code owner March 5, 2025 13:08
@sesi200 sesi200 enabled auto-merge (squash) March 5, 2025 14:24
@sesi200 sesi200 merged commit 7ce72fb into master Mar 5, 2025
299 checks passed
@sesi200 sesi200 deleted the severin/default-to-pocketic branch March 5, 2025 15:10
ggreif added a commit that referenced this pull request Mar 6, 2025
@ggreif
attempt to fix output mismatch
0df19b1 
see #4130 why this is needed
ggreif added a commit that referenced this pull request Mar 6, 2025
@dfinity-bot @ericswanson-dfinity
@sesi200 @ggreif
chore: update replica version to ebb190bf (#4133)
6f074b4 
* chore: update replica version to ebb190bf1da0dba3e486b78c95cf5a3c5542e2f3

* Update CHANGELOG.md

* chore: bump ubuntu (#4131)

* bump `dfx` extension `nns` to 0.5.0

due to test failures

* attempt to fix output mismatch

see #4130 why this is needed

---------

Co-authored-by: ericswanson-dfinity <[email protected]>
Co-authored-by: Severin Siffert <[email protected]>
Co-authored-by: Gabor Greif <[email protected]>
Co-authored-by: Gabor Greif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwshang lwshang lwshang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesi200 @lwshang