Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: second round of ledger commands #205

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

adamspofford-dfinity
Copy link
Contributor

This PR adds support for more Ledger operations, introduced in v2.4 of the ICP app. Many SNS neuron operations remain unsupported, but importantly neurons can now be staked and the full range of NNS neuron functionality is now supported.

This required two changes to the default neuron-staking functionality:

  • The transfers are now made with the ICRC-1 API.
  • The claim-or-refresh call is now unsigned - it seemingly can be made by any user, not just the one that owns the neurons, and this is required for the Ledger functionality as Ledger intentionally rejects claim-or-refresh messages since it does not need to be sent them. The NNS frontend app does this as well.

@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner November 8, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant