feat!: Overhaul CLI #202
Draft
feat!: Overhaul CLI #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neuron-manageis a very confusing command when its options are listed in alphabetical order;transfer,sns transfer, andckbtc transferhave slightly differing parameter names and styles; and several common-between-system features only have CLI support in one system due to falling through these cracks.This PR factors out the neuron-manage command, makes command and argument names consistent where not otherwise illogical, and adds some overlooked features like the ability to spawn to another owner.
neuron-manage and configure-dissolve-delay have been left as-is, but hidden in the UI; other changed names have been left as aliases. Test cases were modified to reflect the new interface, but in each case it was first ensured that all existing commands continued to work. This is a breaking change in spirit, but not in actuality.