feat(moc.js): add blob: import placeholder setting
#5607
+41
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
changed the title
blob: import placeholder flag for moc.jsblob: import placeholder flag for moc.js
rvanasa
changed the title
blob: import placeholder flag for moc.jsblob: import placeholder setting
ggreif
reviewed
Oct 25, 2025
There was a problem hiding this comment.
One could also use https://ocsigen.org/js_of_ocaml/latest/api/js_of_ocaml/Js_of_ocaml/Sys_js/index.html#val-create_file
to just male the file and then let the rest of the mechanism import it.
And there is the mount function too, which would actually allow importing the exact content.
Edit: Oh, I see, having that module conditionally included may be tricky.
This was referenced Oct 27, 2025
ggreif
reviewed
Oct 27, 2025
| assert T.(t = Prim Blob); | ||
| blobE contents | ||
| if !Mo_config.Flags.blob_import_placeholders then | ||
| raise (Invalid_argument ("blob import placeholder")) |
There was a problem hiding this comment.
Alright, block the desugaring!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible (hacky) solution for dfinity/vscode-motoko#394. Tested in VS Code and works as expected.
Adds a
setBlobImportPlaceholders(boolean)function tomoc.jswhich ignores unresolvedblob:imports (trapping at runtime) when enabled. This is a workaround for the virtual file system currently only including Motoko and Candid files from the VS Code workspace.