[VSC-31] Remove intermediate conversion to S-exps #5573
Conversation
|
Dear @alexd1971, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA. If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged. — The DFINITY Foundation |
Problem: The current process for creating a JSON representation of the AST requires an intermediate conversion to S-expression. This hurts performance and makes it impossible to annotate all nodes with types. Solution: Implement a library for converting the original AST directly to JSON, eliminating the intermediate step.
alexd1971
force-pushed
the
grant-2-milestone-1
branch
from
8deed4d to
3101997
Compare
There was a problem hiding this comment.
Thanks for the improvements! Apologies for the delay in reviewing; a lot is happening internally at the moment.
It could be worth investigating whether it's possible to cache / share type representations to reduce the memory and conversion overhead. This would be relevant for larger-scale projects which tend to have a lot of duplicated complex type nodes.
2 participants
Problem: The current process for creating a JS representation of the AST requires an intermediate conversion to S-expression. This hurts performance and makes it impossible to annotate all nodes with types.
Solution: Implement a library for converting the original AST directly to JS, eliminating the intermediate step.