doc: update List.mo
#616
Merged
doc: update List.mo
#616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bugs is doc comments
crusso
commented
Feb 12, 2024
luc-blaeser
reviewed
Feb 12, 2024
| @@ -169,7 +169,9 @@ module { | |||
| /// | |||
| /// Runtime: O(size) | |||
| /// | |||
| /// Space: O(1) | |||
| /// Space: O(size) | |||
There was a problem hiding this comment.
Does the linear size originate from any (internal) temporary allocations during the iterative iteration?
There was a problem hiding this comment.
Yeah, I'm not really sure how to document this. Should it just be 0(1)? If the function allocates non-zero constant space, then I think iterating it should allocate linear space (if the space is retained).
There was a problem hiding this comment.
What about O(space(f))?
(was just passing by...)
luc-blaeser
approved these changes
Feb 12, 2024
ggreif
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs is doc comments