Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Canister limit #357

Closed
wants to merge 1 commit into from
Closed

Canister limit #357

wants to merge 1 commit into from

Conversation

luc-blaeser
Copy link

Add function to query current resource limit for the canister.

@luc-blaeser luc-blaeser requested a review from a team as a code owner November 11, 2024 10:35
Copy link

github-actions bot commented Nov 11, 2024

🤖 Here's your preview: https://pv4ef-vqaaa-aaaak-qidga-cai.icp0.io/docs

@Dfinity-Bjoern
Copy link
Member

This seems a great start, Luc! I assume we want something similar for cycles cost, although, as @mraszyk pointed out in the interface spec meeting, it should probably be a separate call since it's going to return u128 not i64.

Are we planning to move implementation forward on the replica side soon? Is that driven by the execution team @dsarlis?

@dsarlis
Copy link
Member

dsarlis commented Nov 13, 2024

Are we planning to move implementation forward on the replica side soon? Is that driven by the execution team @dsarlis?

This would be a discussion point. I cannot promise soon but we can discuss potential timelines.

@dsarlis
Copy link
Member

dsarlis commented Nov 13, 2024

This seems a great start, Luc! I assume we want something similar for cycles cost, although, as @mraszyk pointed out in the interface spec meeting, it should probably be a separate call since it's going to return u128 not i64.

About this point, yeah, the cycles cost would technically need to return u128 but it might end up similar. One idea we had internally was to expose lower level system api which returns various fees and then CDKs can build higher level abstractions where they combine them in a sensible way. The alternative being to return directly relevant costs, like how much to make this https outcall or ecdsa signature.

The decision would be part of the ticket that we have filed on our side and @michael-weigelt will most likely take on at some point. I personally have a slight preference for the higher level approach of having apis return directly the costs (we can then do some more clever stuff on the replica that is harder to perform on the user level, whether it's CDK or canister code) and it seems more user friendly. But we would have to see what makes the most sense at an API level (the downside of direct costs, is that they depend on size of requests in many cases, making it harder to see a unified API for all costs -- as opposed to a simpler "give me this fee and that fee").

@mraszyk
Copy link
Contributor

mraszyk commented Nov 15, 2024

Superseded by dfinity/portal#3754

@mraszyk mraszyk closed this Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants