feat: Accept an environment as argument for network commands #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viviveevee
reviewed
Jan 12, 2026
Contributor
viviveevee
left a comment
viviveevee
left a comment
There was a problem hiding this comment.
Generally looks good, but the doc comments need some extra newlines
Comment on lines
9
to
25
| /// | ||
| /// # Examples | ||
| /// | ||
| /// # Get status of default 'local' network | ||
| /// icp network status | ||
| /// | ||
| /// # Get status of explicit network | ||
| /// icp network status mynetwork | ||
| /// | ||
| /// # Get status using environment flag | ||
| /// icp network status -e staging | ||
| /// | ||
| /// # Get status using ICP_ENVIRONMENT variable | ||
| /// ICP_ENVIRONMENT=staging icp network status | ||
| /// | ||
| /// # Name overrides ICP_ENVIRONMENT | ||
| /// ICP_ENVIRONMENT=staging icp network status local |
Contributor
There was a problem hiding this comment.
I don't think this renders the way you would like it to, both on the CLI and in the .md file:
lwshang
reviewed
Jan 12, 2026
lwshang
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.