-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [EXC-1675] migrate replica to no-op LogVisibilityV2 #768
Conversation
UPD: it was decided not to do any nns/sns proto message changes. |
I think we can let the NNS team take care of updating their interface if they are interested to use the new log visibility and focus only on updating the replica to use the new type (canisters can still send the old type and we know what to do with it). There's no reason to add a dependency in our process on the NNS/SNS canisters to be upgraded before we can proceed with further steps. |
I had to update |
EDIT: Wait I see it now. This direct dependency on management types is killing us. We need to fix it. I'll try to push for a resolution because we've had similar issues in the past. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo CMC field optionality.
I removed cmc.did change, and added a copy-type to overcome type dependency from management canister. PTAL. |
This PR migrates replica to using a no-op
LogVisibilityV2
instead ofLogVisibility
.The difference between the two is in
AllowedViewers
enum variant which is currently ignored, so it's expected for V2 to behave the same way as V1.