feat(nns): Allow Governance to request rewards from Node Reward canister instead of registry (behind flag) #4693
Conversation
max-dfinity
force-pushed
the
msum/node-rewards-gov-integration
branch
from
19394eb to
77a58cf
Compare
max-dfinity
added
the
CI_OVERRIDE_DIDC_CHECK
max-dfinity
force-pushed
the
msum/node-rewards-gov-integration
branch
from
1d43888 to
ad64597
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
max-dfinity
force-pushed
the
msum/node-rewards-gov-integration
branch
from
5ae8a39 to
b7f2ebe
Compare
What
This allows a test version of governance to rely on the new Node Rewards canister to calculate node rewards. In the normal case, it will continue to rely on Registry.
We also fix an issue in the Node Reward canister, where a query was used when an update should have been used. Since this canister is not yet considered "live" and this API endpoint should not yet be relied upon, we are overriding the DIDC_CHECK on backwards compatibility.
Why
This is part of the effort to allow node rewards to be calculated based on useful work.