feat(sns): Extend cast_vote_and_cascade_follow to take topic-based following into account#4583
Merged
feat(sns): Extend cast_vote_and_cascade_follow to take topic-based following into account#4583
cast_vote_and_cascade_follow to take topic-based following into account#4583Conversation
aterga
force-pushed
the
arshavir/NNS1-3711-2
branch
from
be9a1b5 to
31e7d12
Compare
aterga
commented
Mar 31, 2025
aterga
commented
Mar 31, 2025
aterga
commented
Mar 31, 2025
aterga
commented
Mar 31, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
aterga
dismissed
github-actions[bot]’s stale review
No canister behavior changes (since topic-based following cannot be added yet).
…o a new submodule
max-dfinity
reviewed
Apr 1, 2025
max-dfinity
reviewed
Apr 1, 2025
max-dfinity
approved these changes
Apr 1, 2025
max-dfinity
reviewed
Apr 3, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 10, 2025
This PR changes the default following for neurons in the swap neuron basket to be defined in terms of topic-based following, as opposed to proposal type-based following. The follows the design proposed in https://forum.dfinity.org/t/sns-topics-plan < [Previous PR](#4583) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements topic-based following, which legacy (function-based) following is kept as a fallback.
< Previous PR | Next PR >