fix: cargo build registry-canister for wasm32 target #3408
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following command would fail to compile the registry canister if run from the /ic/rs/registery/canister sub-directory:
cargo build --profile canister-release --target wasm32-unknown-unknown --bin registry-canister
The fix is to make sure the feature
getrandom/custom
is enabled.Note that the above command would succeed if run from the top-level directory, but would produce wrong wasm binary. This is because cargo would bring in global dependencies that enable both
getrandom/custom
andgetrandom/js
features, and the latter will lead to wasm binaries having unwanted imports (See #3309 for more details).Since this problem does not affect bazel builds, this fix is only relevant to cargo.