feat: list topics #3394
Draft
feat: list topics #3394
+346
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/topics
branch
from
fc0b2f1 to
147cc8a
Compare
anchpop
force-pushed
the
@anchpop/clean-up-api
branch
from
8ed9ba7 to
25d8f70
Compare
anchpop
force-pushed
the
@anchpop/topics
branch
from
147cc8a to
77f82ee
Compare
aterga
reviewed
Jan 10, 2025
| @@ -822,6 +870,26 @@ type GetUpgradeJournalResponse = record { | |||
| upgrade_journal_entry_count: opt nat64; | |||
| }; | |||
|
|
|||
| type ListTopicsRequest = record {}; | |||
|
|
|||
| type BuiltInAndGenericFunctions = record { | |||
There was a problem hiding this comment.
Let's think about the name of this type. Maybe just NervousSystemFunctions?
aterga
reviewed
Jan 10, 2025
| name : text; | ||
| description : text; | ||
| content : BuiltInAndGenericFunctions; | ||
| nested_topics : vec TopicInfo; |
There was a problem hiding this comment.
Not sure we want this. Let's agree on the design level if we need nested topics.
aterga
reviewed
Jan 10, 2025
| description : text; | ||
| content : BuiltInAndGenericFunctions; | ||
| nested_topics : vec TopicInfo; | ||
| critical : bool; |
There was a problem hiding this comment.
Nit
Suggested change
| critical : bool; | |
| is_critical : bool; |
anchpop
force-pushed
the
@anchpop/clean-up-api
branch
from
25d8f70 to
45da517
Compare
anchpop
force-pushed
the
@anchpop/topics
branch
2 times, most recently
from
11fc3fd to
583f14b
Compare
anchpop
force-pushed
the
@anchpop/clean-up-api
branch
from
45da517 to
fd398fe
Compare
anchpop
force-pushed
the
@anchpop/topics
branch
from
583f14b to
4133d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.