feat(node): Configuration revamp (HostOS integration) #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbattat
commented
Jan 9, 2025
There was a problem hiding this comment.
guestos/setup-hostname.sh will be deleted when GuestOS moves to the config revamp and we will used the consolidated, top level setup-hostname.sh
andrewbattat
commented
Jan 9, 2025
There was a problem hiding this comment.
We are continuing to pass the old config to the GuestOS. This will be removed once the whole IC-OS has been updated to use the new config and we no longer need the backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-1466
This PR integrates the config tool into HostOS. The config tool is utilized for config sanitization, organization, and access.
Note that the old config is still being passed to GuestOS, so this PR should have no impact on GuestOS