Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ckbtc): Upgrade bitcoin version used in ckbtc minter #3275

Draft
wants to merge 7 commits into
base: mihailjianu1/bitcoin-crate-upgrade
Choose a base branch
from

Conversation

ninegua
Copy link
Member

@ninegua ninegua commented Dec 20, 2024

XC-263: ckBTC minter: upgrade bitcoin crate

@github-actions github-actions bot added the chore label Dec 20, 2024
@ninegua
Copy link
Member Author

ninegua commented Dec 20, 2024

//rs/bitcoin/ckbtc/minter:ckbtc_minter_lib_unit_tests fails to build at linking stage:

  = note: ld.lld: error: undefined symbol: secp256k1_context_no_precomp

It is a similar problem we had before, see #1032 (comment)

  • We previously added --cfg=rust_secp_no_symbol_renaming flag to compile secp256k1-sys to avoid linking in external symbols from secp256k1 C library, which is required when compiling wasm32 target for those that imports bitcoin crates. This is still in effect.
  • However, if we link the same version of secp256k1-sys when compiling tests of x86 target, the linking will fail because it actually requires the C library. This is why ckbtc_minter_lib_unit_tests fails to compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant