Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IDX): don't cache ic-os images #3256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Dec 19, 2024

This saves a couple gigabytes of cache space per build:

ubuntu@devenv-container:/ic$ bazel --noworkspace_rc --bazelrc=./bazel/conf/.bazelrc.build build --disk_cache=,out/disk-cache --config=systest //ic-os/setupos/envs/dev && du -sh ,out
...
Target //ic-os/setupos/envs/dev:dev up-to-date:
  bazel-bin/ic-os/setupos/envs/dev/dev_pre_check_result.txt
  bazel-bin/ic-os/setupos/envs/dev/disk-img.tar.zst
INFO: Elapsed time: 0.929s, Critical Path: 0.10s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
24G	,out

ubuntu@devenv-container:/ic$ bazel --noworkspace_rc --bazelrc=./bazel/conf/.bazelrc.build build --disk_cache=,out/disk-cache --config=systest //ic-os/setupos/envs/dev && du -sh ,out
...
Target //ic-os/setupos/envs/dev:dev up-to-date:
  bazel-bin/ic-os/setupos/envs/dev/dev_pre_check_result.txt
  bazel-bin/ic-os/setupos/envs/dev/disk-img.tar.zst
INFO: Elapsed time: 0.857s, Critical Path: 0.04s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
6.9G	,out # NOTE: this is when everything in ic-os is marked as no-cache

The images are rebuilt on almost every change anyway.

@github-actions github-actions bot added the chore label Dec 19, 2024
@nmattia nmattia marked this pull request as ready for review December 19, 2024 14:03
@nmattia nmattia requested a review from a team as a code owner December 19, 2024 14:03
@github-actions github-actions bot added the @node label Dec 19, 2024
@nmattia nmattia marked this pull request as draft December 19, 2024 14:04
This saves a couple gigabytes of cache space per build:

```
ubuntu@devenv-container:/ic$ bazel --noworkspace_rc --bazelrc=./bazel/conf/.bazelrc.build build --disk_cache=,out/disk-cache --config=systest //ic-os/setupos/envs/dev && du -sh ,out
...
Target //ic-os/setupos/envs/dev:dev up-to-date:
  bazel-bin/ic-os/setupos/envs/dev/dev_pre_check_result.txt
  bazel-bin/ic-os/setupos/envs/dev/disk-img.tar.zst
INFO: Elapsed time: 0.929s, Critical Path: 0.10s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
24G	,out

ubuntu@devenv-container:/ic$ bazel --noworkspace_rc --bazelrc=./bazel/conf/.bazelrc.build build --disk_cache=,out/disk-cache --config=systest //ic-os/setupos/envs/dev && du -sh ,out
...
Target //ic-os/setupos/envs/dev:dev up-to-date:
  bazel-bin/ic-os/setupos/envs/dev/dev_pre_check_result.txt
  bazel-bin/ic-os/setupos/envs/dev/disk-img.tar.zst
INFO: Elapsed time: 0.857s, Critical Path: 0.04s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
6.9G	,out
```

The images are rebuilt on almost every change anyway.
@nmattia nmattia marked this pull request as ready for review December 20, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant