Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(crypto): CRP-2649 refactor vetKD key share creation vault tests #3251

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

test(crypto): CRP-2649 refactor vetKD key share creation vault tests #3251

wants to merge 5 commits into from
+476 −19

Conversation

fspreiss
Copy link
Member

No description provided.

@github-actions github-actions bot added the test label Dec 19, 2024
@fspreiss fspreiss mentioned this pull request Dec 19, 2024
Merged
@fspreiss fspreiss requested a review from randombit December 19, 2024 15:07
Base automatically changed from franzstefan/CRP-2649-vetkd-key-share-creation-vault-method to master December 19, 2024 15:51
randombit
randombit approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fspreiss this to me seems a better approach overall, especially if/when more test cases are added. [Only reviewed the final commit, I assume the rest are from the prior PR]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randombit randombit randombit approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fspreiss @randombit