feat: call bitcoin canisters #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
reviewed
Mar 5, 2025
e2e-tests/tests/bitcoin_canister.rs
Outdated
| disable_api_if_not_fully_synced = variant { enabled }; | ||
| }, | ||
| )"#; | ||
| test_one_network(Network::Mainnet, mainnet_id, mainnet_init_args); |
THLO
reviewed
Mar 5, 2025
e2e-tests/tests/bitcoin_canister.rs
Outdated
| } | ||
|
|
||
| fn test_one_network(network: Network, btc_id: Principal, init_args: &str) { | ||
| // The Bitcoin Canisters can still function without connecting to a `bitcoind` node. |
There was a problem hiding this comment.
Suggested change
| // The Bitcoin Canisters can still function without connecting to a `bitcoind` node. | |
| // The Bitcoin canisters can still function without connecting to a `bitcoind` node. |
THLO
reviewed
Mar 5, 2025
ic-cdk/src/bitcoin_canister.rs
Outdated
| @@ -8,3 +8,340 @@ | |||
| //! [2]: https://github.com/dfinity/bitcoin-canister/blob/master/INTERFACE_SPECIFICATION.md | |||
|
|
|||
| // TODO: Implementation of the Bitcoin Canister API | |||
THLO
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Bitcoin API has been migrated from management canister to calling the Bitcoin Canisters directly.
This PR implements the types and functions in
bitcoin_canister.rsmodule.This module follows a similar approach in the
management_canister.rsmodule. Please note:ic-btc-interfacecrate because it contains some implementation specific details that harm the user experiences. E.g. theNetworkInRequesttype would make users confused.*_querymethods are not included because they cannot be called in replicated mode (inter-canister calls).*_configmethods are not included because they are for the maintainers of the Bitcoin CanistersHow Has This Been Tested?
Added:
Checklist: