Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EES-5554 Fix accessibility issues in public API docs #5589

Merged
merged 6 commits into from
Feb 6, 2025
Merged

EES-5554 Fix accessibility issues in public API docs #5589

merged 6 commits into from
Feb 6, 2025

Conversation

ntsim
Copy link
Collaborator

@ntsim ntsim commented Feb 4, 2025

This PR fixes various accessibility issues that have been highlighted by @N-moh

  • Added unique aria-label / aria-labelledby attributes for parameter tables
  • Fixed header appearing really broken at 200%+ zoom
  • Fixed overflowing text from large word breaking the entire layout at 200%+ zoom (using word-break)
  • Fixed mobile TOC styling being mostly broken when 200%+ zoom

Additionally, I've made some more tweaks whilst in the area:

  • Fixed 'Endpoints' and 'Schemas' child items not being displayed in the mobile TOC
  • Fixed parameter table styling being mostly broken at 200%+ zoom

Screenshots

New header:

image

New TOC:

image

New parameter tables:

image

Copy link
Collaborator

@amyb-hiveit amyb-hiveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get this running locally to fully check, but I think this all looks ok.

I did find another issue that hasn't been raised, though I don't know if it's something we can fix or if it's outside of our control - the heading level on search results skips from h1 to h3:
Screenshot 2025-02-06 111935

@ntsim ntsim merged commit 8b37fae into dev Feb 6, 2025
10 checks passed
@ntsim ntsim deleted the ees-5554 branch February 6, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants