EES-5819 Can specify chromedriver version in UI tests pipeline run sc… #5560
Conversation
| parser.add_argument( | ||
| "--chromedriver", | ||
| dest="chromedriver_version", | ||
| metavar="{version}", | ||
| help="specify which version of chromedriver to use", | ||
| ) |
There was a problem hiding this comment.
Webdriver manager tries to find the closest matching Chromedriver for the browser version already. Could this lead to us forgetting that we've pinned the Chromedriver version in the pipeline when it should already be the closest match?
Maybe there is still some value in this change if a particular version of chromedriver has a problem, we could use this to try temporarily downgrading?
There was a problem hiding this comment.
Talked to Ben about this on Slack - don't think either of us are fussed either way, so we'll close it
|
Webdriver manager automatically chooses a chromedriver version appropriate for your google-chrome version, so this isn't necessary - arguable that it could be used for an older version to avoid an issue but we've not needed that before, so just closing this PR instead of merging it. |
…ript
This PR allows us to specify the chromedriver version we want to use when using the UI tests pipeline run script.