Skip to content

Commit

Permalink
EES-5188 update node to v20.14.0
Browse files Browse the repository at this point in the history
  • Loading branch information
amyb-hiveit committed Jun 6, 2024
1 parent 191fd95 commit c0b9d09
Show file tree
Hide file tree
Showing 6 changed files with 310 additions and 231 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.18.2
20.14.0
2 changes: 1 addition & 1 deletion azure-pipelines.dfe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ variables:
BuildConfiguration: 'Release'
IsBranchDeployable: ${{ containsValue(parameters.DeployBranches, variables['Build.SourceBranchName']) }}
CI: true
NODE_VERSION: 18.18.2
NODE_VERSION: 20.14.0
AcrServiceConnection: s101d-datahub-spn-ees-dfe-gov-uk-docker-managed-service-connection

trigger:
Expand Down
2 changes: 1 addition & 1 deletion docker/public-frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.18.2-alpine AS base
FROM node:20.14.0-alpine AS base

ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
Expand Down
8 changes: 4 additions & 4 deletions infrastructure/templates/template.json
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,7 @@
],
"properties": {
"APPINSIGHTS_INSTRUMENTATIONKEY": "[reference(resourceId('microsoft.insights/components/', variables('dataAppInsights')), '2020-02-02').InstrumentationKey]",
"WEBSITE_NODE_DEFAULT_VERSION": "14.16.0",
"WEBSITE_NODE_DEFAULT_VERSION": "20.14.0",
"WEBSITE_RUN_FROM_PACKAGE": "1",
"PublicStorage": "[concat('@Microsoft.KeyVault(SecretUri=', reference(variables('ees-storage-public'), '2018-02-14').secretUriWithVersion, ')')]",
"enableSwagger": "[parameters('enableSwagger')]",
Expand Down Expand Up @@ -1475,7 +1475,7 @@
],
"properties": {
"APPINSIGHTS_INSTRUMENTATIONKEY": "[reference(resourceId('microsoft.insights/components/', variables('contentAppInsights')), '2020-02-02').InstrumentationKey]",
"WEBSITE_NODE_DEFAULT_VERSION": "14.16.0",
"WEBSITE_NODE_DEFAULT_VERSION": "20.14.0",
"WEBSITE_RUN_FROM_PACKAGE": "1",
"PublicStorage": "[concat('@Microsoft.KeyVault(SecretUri=', reference(variables('ees-storage-public'), '2018-02-14').secretUriWithVersion, ')')]",
"enableSwagger": "[parameters('enableSwagger')]"
Expand Down Expand Up @@ -1704,7 +1704,7 @@
"properties": {
"APPINSIGHTS_INSTRUMENTATIONKEY": "[reference(resourceId('microsoft.insights/components/', variables('adminAppInsights')), '2020-02-02').InstrumentationKey]",
"AppInsights__InstrumentationKey": "[reference(resourceId('microsoft.insights/components/', variables('adminAppInsights')), '2020-02-02').InstrumentationKey]",
"WEBSITE_NODE_DEFAULT_VERSION": "14.16.0",
"WEBSITE_NODE_DEFAULT_VERSION": "20.14.0",
"WEBSITE_RUN_FROM_PACKAGE": "1",
"WEBSITE_LOAD_CERTIFICATES": "*",
"ASPNETCORE_DETAILEDERRORS": "[parameters('detailedErrors')]",
Expand Down Expand Up @@ -2061,7 +2061,7 @@
"NEXT_CONFIG_MODE": "server",
"NODE_ENV": "production",
"PUBLIC_URL": "[concat(variables('publicAppUrl'), '/')]",
"WEBSITE_NODE_DEFAULT_VERSION": "18.18.2",
"WEBSITE_NODE_DEFAULT_VERSION": "20.14.0",
"WEBSITES_PORT": 3000
}
},
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "module",
"packageManager": "[email protected]",
"engines": {
"node": "18.18.2",
"node": "20.14.0",
"pnpm": ">=8.8.0"
},
"devDependencies": {
Expand Down Expand Up @@ -42,7 +42,7 @@
"stylelint-config-sass-guidelines": "^10.0.0",
"stylelint-prettier": "^4.0.2",
"tree-kill": "^1.2.2",
"ts-node": "^10.9.1",
"tsx": "^4.12.0",
"typescript": "^5.1.6"
},
"scripts": {
Expand All @@ -63,7 +63,7 @@
"lint:js": "eslint --ext .ts,.tsx,.js,.jsx .",
"lint:python": "python3 -m pipenv run flake8 tests",
"lint:style": "stylelint src/**/*.{scss,css}",
"start": "ts-node useful-scripts/start.ts",
"start": "tsx useful-scripts/start.ts",
"test": "pnpm -r --no-bail test",
"test:snapshot": "pnpm -r --no-bail test:snapshot",
"test:ci": "pnpm -r --no-bail --aggregate-output --reporter=append-only test:ci",
Expand Down
Loading

0 comments on commit c0b9d09

Please sign in to comment.