Update @typescript-eslint to 7.18.0

dfe-analytical-services · Sep 6, 2024 · 8689a20 · 8689a20
1 parent 35cff48
commit 8689a20
Show file tree

Hide file tree

Showing 6 changed files with 394 additions and 164 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -30,7 +30,12 @@
     "@typescript-eslint/ban-ts-ignore": "off",
     "@typescript-eslint/default-param-last": "error",
     "@typescript-eslint/explicit-function-return-type": "off",
-    "@typescript-eslint/no-empty-function": "off",
+    "@typescript-eslint/no-empty-function": [
+      "error",
+      {
+        "allow": ["arrowFunctions", "functions", "methods"]
+      }
+    ],
     "@typescript-eslint/no-shadow": "error",
     "@typescript-eslint/no-unused-vars": [
       "warn",
@@ -45,9 +50,13 @@
     "import/no-cycle": "off",
     "import/no-extraneous-dependencies": ["error", { "devDependencies": true }],
     "import/no-unresolved": "off",
-    "lines-between-class-members": ["error", "always", {
-      "exceptAfterSingleLine": true
-    }],
+    "lines-between-class-members": [
+      "error",
+      "always",
+      {
+        "exceptAfterSingleLine": true
+      }
+    ],
     "react/forbid-prop-types": "off",
     "react/function-component-definition": "off",
     "react/no-unstable-nested-components": [
@@ -78,7 +87,7 @@
       }
     ],
     "react/jsx-curly-newline": "off",
-    "react/jsx-no-useless-fragment": ["error", { "allowExpressions":  true}],
+    "react/jsx-no-useless-fragment": ["error", { "allowExpressions": true }],
     "react/jsx-one-expression-per-line": "off",
     "react/jsx-props-no-spreading": [
       "error",
@@ -100,6 +109,7 @@
         "assert": "htmlFor"
       }
     ],
+    "no-empty-function": "off",
     "no-console": "warn",
     "no-param-reassign": [
       "error",
@@ -161,7 +171,10 @@
       "extends": ["plugin:@next/next/recommended"],
       "rules": {
         "@next/next/no-img-element": "off",
-        "@next/next/no-html-link-for-pages": ["error", ["src/pages", "src/explore-education-statistics-frontend/src/pages"]]
+        "@next/next/no-html-link-for-pages": [
+          "error",
+          ["src/pages", "src/explore-education-statistics-frontend/src/pages"]
+        ]
       }
     }
   ]

diff --git a/package.json b/package.json
@@ -15,14 +15,14 @@
     "@types/node": "^18.17.5",
     "@types/signal-exit": "^3.0.1",
     "@types/split2": "^4.2.0",
-    "@typescript-eslint/eslint-plugin": "^5.61.0",
-    "@typescript-eslint/parser": "^5.61.0",
+    "@typescript-eslint/eslint-plugin": "^7.18.0",
+    "@typescript-eslint/parser": "^7.18.0",
     "caniuse-lite": "^1.0.30001610",
     "chalk": "^5.3.0",
     "check-node-version": "^4.2.1",
     "commander": "^11.0.0",
     "cross-process-lock": "^2.1.1",
-    "eslint": "^8.43.0",
+    "eslint": "^8.57.0",
     "eslint-config-airbnb": "^19.0.4",
     "eslint-config-next": "^12.3.4",
     "eslint-config-prettier": "^8.8.0",
@@ -43,7 +43,7 @@
     "stylelint-prettier": "^4.0.2",
     "tree-kill": "^1.2.2",
     "tsx": "^4.12.0",
-    "typescript": "^5.2.0"
+    "typescript": "^5.5.4"
   },
   "scripts": {
     "prepare": "husky install",
@@ -89,4 +89,4 @@
       "pipenv run isort"
     ]
   }
-}
+}