Skip to content

Commit

Permalink
Adjusting how the cookies link button is rendered
Browse files Browse the repository at this point in the history
  • Loading branch information
rmbielby committed Feb 13, 2024
1 parent ed99f80 commit fb05a29
Showing 1 changed file with 32 additions and 39 deletions.
71 changes: 32 additions & 39 deletions R/cookies.R
Original file line number Diff line number Diff line change
Expand Up @@ -36,56 +36,49 @@ dfe_cookie_script <- function() {
#' @examples
#' cookieBannerUI("cookies", name = "My DfE R-Shiny data dashboard")
cookieBannerUI <- function(id, name = "DfE R-Shiny dashboard template") {

Check notice

Code scanning / lintr

Variable and function name style should match snake_case or symbols. Note

Variable and function name style should match snake_case or symbols.
value <- shiny::restoreInput(id = NS(id, "cookieLink"), default = NULL)
govCookieLink <- shiny::tags$button(
"View cookies",
NS(id, "cookieLink"),
class = paste0("govuk-link", " action-button"),
`data-val` = value
)

attachDependency(govCookieLink)

cookieBanner_Input <-
tags$div(

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'

Check warning

Code scanning / lintr

no visible binding for global variable 'tags' Warning

no visible binding for global variable 'tags'
id = NS(id, "cookieDiv"),

Check warning

Code scanning / lintr

no visible global function definition for 'NS' Warning

no visible global function definition for 'NS'

Check warning

Code scanning / lintr

no visible global function definition for 'NS' Warning

no visible global function definition for 'NS'

Check warning

Code scanning / lintr

no visible global function definition for 'NS' Warning

no visible global function definition for 'NS'

Check warning

Code scanning / lintr

no visible global function definition for 'NS' Warning

no visible global function definition for 'NS'

Check warning

Code scanning / lintr

no visible global function definition for 'NS' Warning

no visible global function definition for 'NS'
class = "govuk-cookie-banner",
`data-nosnippet role` = "region",
`aria-label` = "Cookies on name",
tags$div(
id = NS(id, "cookieDiv"),
class = "govuk-cookie-banner",
`data-nosnippet role` = "region",
`aria-label` = "Cookies on name",
id = NS(id, "cookieMain"),
class = "govuk-cookie-banner__message govuk-width-container",
tags$div(
id = NS(id, "cookieMain"),
class = "govuk-cookie-banner__message govuk-width-container",
class = "govuk-grid-row",
tags$div(
class = "govuk-grid-row",
class = "govuk-grid-column-two-thirds",
tags$h2(
class = "govuk-cookie-banner__heading govuk-heading-m",
name
),
tags$div(
class = "govuk-grid-column-two-thirds",
tags$h2(
class = "govuk-cookie-banner__heading govuk-heading-m",
name
class = "govuk-cookie-banner__content",
tags$p(
class = "govuk-body",
"We use some essential cookies to make this service work."
),
tags$div(
class = "govuk-cookie-banner__content",
tags$p(
class = "govuk-body",
"We use some essential cookies to make this service work."
),
tags$p(
class = "govuk-body",
"We'd also like to use analytics cookies so we can understand
tags$p(
class = "govuk-body",
"We'd also like to use analytics cookies so we can understand
how you use the service and make improvements."
)
)
)
),
tags$div(
class = "govuk-button-group",
button_Input(NS(id, "cookieAccept"), "Accept analytics cookies"),
button_Input(NS(id, "cookieReject"), "Reject analytics cookies"),
govCookieLink
)
),
tags$div(
class = "govuk-button-group",
button_Input(NS(id, "cookieAccept"), "Accept analytics cookies"),

Check warning

Code scanning / lintr

no visible global function definition for 'button_Input' Warning

no visible global function definition for 'button_Input'

Check warning

Code scanning / lintr

no visible global function definition for 'button_Input' Warning

no visible global function definition for 'button_Input'
button_Input(NS(id, "cookieReject"), "Reject analytics cookies"),
shiny::tags$button(
"View cookies",
NS(id, "cookieLink"),
class = paste0("govuk-link", " action-button"),
`data-val` = value

Check warning

Code scanning / lintr

no visible binding for global variable 'value' Warning

no visible binding for global variable 'value'
)
)
)
attachDependency(cookieBanner_Input)
)
}

#' cookieBannerServer
Expand Down

0 comments on commit fb05a29

Please sign in to comment.