Skip to content

Commit

Permalink
add UI test for cookies information link (#78)
Browse files Browse the repository at this point in the history
* add UI test for cookies information link

* update test snapshots

* stop lintr flagging commented out code issue

* sometimes lintr really does do your nut in
  • Loading branch information
cjrace authored Jan 2, 2025
1 parent 82b9566 commit 0b7bb67
Show file tree
Hide file tree
Showing 6 changed files with 57 additions and 37 deletions.
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"input": {
"cookies": {
"dfe_analytics": "granted"

},
"cookies_banner-cookies_accept": 1,
"cookies_banner-cookies_link": 0,
"cookies_banner-cookies_accept": 0,
"cookies_banner-cookies_link": 1,
"cookies_banner-cookies_reject": 0,
"cookies_panel-cookies_analytics": "yes",
"cookies_panel-cookies_analytics": "no",
"cookies_panel-submit_btn": 0,
"navlistPanel": "support_panel"
"navlistPanel": "cookies_panel_ui"
},
"output": {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"input": {
"cookies": {
"dfe_analytics": "denied"
"dfe_analytics": "granted"
},
"cookies_banner-cookies_accept": 1,
"cookies_banner-cookies_link": 0,
"cookies_banner-cookies_reject": 1,
"cookies_panel-cookies_analytics": "no",
"cookies_banner-cookies_link": 1,
"cookies_banner-cookies_reject": 0,
"cookies_panel-cookies_analytics": "yes",
"cookies_panel-submit_btn": 0,
"navlistPanel": "support_panel"
"navlistPanel": "cookies_panel_ui"
},
"output": {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"input": {
"cookies": {
"dfe_analytics": "granted"
"dfe_analytics": "denied"
},
"cookies_banner-cookies_accept": 1,
"cookies_banner-cookies_link": 0,
"cookies_banner-cookies_link": 1,
"cookies_banner-cookies_reject": 1,
"cookies_panel-cookies_analytics": "yes",
"cookies_panel-submit_btn": 1,
"navlistPanel": "support_panel"
"cookies_panel-cookies_analytics": "no",
"cookies_panel-submit_btn": 0,
"navlistPanel": "cookies_panel_ui"
},
"output": {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"input": {
"cookies": {
"dfe_analytics": "denied"
"dfe_analytics": "granted"
},
"cookies_banner-cookies_accept": 1,
"cookies_banner-cookies_link": 0,
"cookies_banner-cookies_link": 1,
"cookies_banner-cookies_reject": 1,
"cookies_panel-cookies_analytics": "no",
"cookies_panel-submit_btn": 2,
"navlistPanel": "support_panel"
"cookies_panel-cookies_analytics": "yes",
"cookies_panel-submit_btn": 1,
"navlistPanel": "cookies_panel_ui"
},
"output": {

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"input": {
"cookies": {
"dfe_analytics": "denied"
},
"cookies_banner-cookies_accept": 1,
"cookies_banner-cookies_link": 1,
"cookies_banner-cookies_reject": 1,
"cookies_panel-cookies_analytics": "no",
"cookies_panel-submit_btn": 2,
"navlistPanel": "cookies_panel_ui"
},
"output": {

},
"export": {

}
}
35 changes: 18 additions & 17 deletions tests/test_dashboard/tests/testthat/test-UI-02-cookies.R
Original file line number Diff line number Diff line change
@@ -1,42 +1,43 @@
# To run the diffviewer on these tests, you need to add the path:
# Doesn't work? testthat::snapshot_review('UI-02-cookies/', path='tests/test_dashboard/')
# like this! testthat::snapshot_review('UI-02-cookies/', path='tests/test_dashboard/tests/testthat')
app <- AppDriver$new(
name = "cookies_consent",
expect_values_screenshot_args = FALSE
)

app$wait_for_idle(50)

app$click("cookies_banner-cookies_accept")
app$wait_for_idle(50)
test_that("Can click view cookie information", {
app$click("cookies_banner-cookies_link")
app$wait_for_idle(50)
app$expect_values()
})

test_that("Cookies accepted banner", {
app$click("cookies_banner-cookies_accept")
app$wait_for_idle(50)
app$expect_values()
})

app$click("cookies_banner-cookies_reject")
app$wait_for_idle(50)

test_that("Cookies rejected banner", {
app$click("cookies_banner-cookies_reject")
app$wait_for_idle(50)
app$expect_values()
})

app$set_inputs(`cookies_panel-cookies_analytics` = "yes")
app$wait_for_idle(50)

app$click("cookies_panel-submit_btn")
app$wait_for_idle(50)

test_that("Cookies accepted page", {
app$set_inputs(`cookies_panel-cookies_analytics` = "yes")
app$wait_for_idle(50)
app$click("cookies_panel-submit_btn")
app$wait_for_idle(50)
app$expect_values()
})

app$set_inputs(`cookies_panel-cookies_analytics` = "no")
app$wait_for_idle(50)

app$click("cookies_panel-submit_btn")
app$wait_for_idle(50)

test_that("Cookies rejected page", {
app$set_inputs(`cookies_panel-cookies_analytics` = "no")
app$wait_for_idle(50)
app$click("cookies_panel-submit_btn")
app$wait_for_idle(50)
app$expect_values()
})

0 comments on commit 0b7bb67

Please sign in to comment.