Return DEVICE_UNREACHABLE for device without states (close #453)

dext0r · Oct 13, 2023 · d41560a · d41560a
1 parent 276029d
commit d41560a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/custom_components/yandex_smart_home/device.py b/custom_components/yandex_smart_home/device.py
@@ -319,6 +319,9 @@ def query(self) -> DeviceState:
             if (property_state := p.get_instance_state()) is not None:
                 properties.append(property_state)
 
+        if not capabilities and not properties:
+            return DeviceState(id=self.id, error_code=ResponseCode.DEVICE_UNREACHABLE)
+
         return DeviceState(id=self.id, capabilities=capabilities, properties=properties)
 
     async def execute(

diff --git a/tests/test_device.py b/tests/test_device.py
@@ -510,6 +510,10 @@ async def set_instance_state(self, _: Context, __: ToggleCapabilityInstanceActio
             "properties": [{"type": "devices.properties.float", "state": {"instance": "temperature", "value": 5.0}}],
         }
 
+        state_temp.state = STATE_UNAVAILABLE
+        with patch.object(Device, "get_capabilities", return_value=[cap_pause]):
+            assert device.query().as_dict() == {"id": "switch.test", "error_code": "DEVICE_UNREACHABLE"}
+
 
 async def test_device_execute(hass, caplog):
     state = State("switch.test", STATE_ON)