Prevent rules being applied to all feeds #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described by itohsnap (cf. dewey#13 (comment)) all rules of the killfile were being applied to each feed. This clumsy change prevents that by making sure the feed’s URL matches the rule’s URL in `evaluateRules`. There’s probably a more elegant way of doing this, but I’m not a programmer and simply desperately needed this to work. Maybe someone else can use it. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by @itohsnap in issue #13 all rules of the killfile were being applied to each feed. This clumsy change prevents that by making sure the feed’s URL matches the rule’s URL in
evaluateRules.There’s probably a more elegant way of doing this, but I’m not a programmer and simply desperately needed this to work. Maybe someone else can use it. :-)