Skip to content

Commit

Permalink
ci: properly build dev-app for automatic deploy
Browse files Browse the repository at this point in the history
The deploy script seems rather legacy and also doesn't ensure
that the dist directory is actually present. We can simplify
the logic and potentially delete the script in the future.
  • Loading branch information
devversion committed Nov 2, 2023
1 parent 47341ac commit 3687343
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/deploy-dev-app-main-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ jobs:
- name: Setup Bazel RBE
uses: angular/dev-infra/github-actions/bazel/configure-remote@fb30926790c6225d553b91a4818cab2fdde4fb4e

- run: yarn -s deploy-dev-app
- name: Building dev-app
run: |
yarn -s bazel build //src/dev-app:web_package --symlink_prefix=dist/
cp -R dist/bin/src/dev-app/web_package dist/dev-app-web-pkg
- name: Configure Firebase deploy target
run: |
Expand All @@ -39,6 +42,7 @@ jobs:
repoToken: ''
firebaseServiceAccount: '${{secrets.FIREBASE_PREVIEW_SERVICE_TOKEN}}'
projectId: '${{env.PREVIEW_PROJECT}}'
entryPoint: './'
channelId: '${{env.PREVIEW_CHANNEL}}'

- name: Result
Expand Down

0 comments on commit 3687343

Please sign in to comment.