Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: async flow and integrate prom-client #91

Merged
merged 14 commits into from
Nov 18, 2024
Merged

fix: async flow and integrate prom-client #91

merged 14 commits into from
Nov 18, 2024

Conversation

arunjaindev
Copy link
Contributor

No description provided.

@arunjaindev arunjaindev changed the base branch from develop to main October 22, 2024 06:14
@arunjaindev arunjaindev changed the base branch from main to develop October 22, 2024 06:15
eshankvaish
eshankvaish reviewed Oct 23, 2024
View reviewed changes
src/server.ts Outdated Show resolved Hide resolved
eshankvaish
eshankvaish requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@eshankvaish eshankvaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repetitive changes. Please fix and then I'll review the whole PR

src/destination/destinationHandlers/sesHandler.ts Outdated Show resolved Hide resolved
src/destination/destinationHandlers/sesHandler.ts Outdated Show resolved Hide resolved
src/destination/destinationHandlers/slackHandler.ts Outdated Show resolved Hide resolved
eshankvaish
eshankvaish requested changes Oct 24, 2024
View reviewed changes
src/server.ts Show resolved Hide resolved
src/server.ts Outdated Show resolved Hide resolved
src/pubSub/pubSub.ts Show resolved Hide resolved
src/notification/service/notificationService.ts Show resolved Hide resolved
src/common/metrics.ts Outdated Show resolved Hide resolved
eshankvaish
eshankvaish previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@eshankvaish eshankvaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunjaindev we still need to verify: #91 (comment)

@arunjaindev arunjaindev changed the title fix: async flow fix: async flow and integrate prom-client Oct 29, 2024
@arunjaindev arunjaindev merged commit 2bc0d6a into develop Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshankvaish eshankvaish eshankvaish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunjaindev @eshankvaish @vivek-devtron