Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid UTF-8 characters in commit message #67

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Sep 19, 2023

Description

For gRPC clients fetch git commits for pipelineId is breaking incase the commit message contains invalid UTF-8 characters.

Fixes devtron-labs/devtron#3930

How Has This Been Tested?

  • Existing Git Material
    • commits having invalid UTF-8 in commit message
    • valid commit messages
  • Create New Git Material
    • commits having invalid UTF-8 in commit message
    • valid commit messages

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@Ash-exp Ash-exp added the enhancement New feature or request label Sep 19, 2023
@Ash-exp Ash-exp self-assigned this Sep 19, 2023
@Ash-exp Ash-exp merged commit b6c3ea0 into main Sep 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ci pipeline material api giving 500 for those application having invalid UTF-8 character in git commits
2 participants