chore: refactoring mandatory plugin v2 #6056
Conversation
Ash-exp
requested review from
prakarsh-dt,
vikramdevtron and
nishant-d
as code owners
| @@ -0,0 +1,57 @@ | |||
| package sliceUtil | |||
There was a problem hiding this comment.
we need to add test cases for these functions
There was a problem hiding this comment.
these functions seems useful as we do these operations at multiple places. we will start using these . so proper test cases are required
| return impl.GetAllPluginMinDataByType("") | ||
| } | ||
|
|
||
| func (impl *GlobalPluginRepositoryImpl) GetAllPluginMinDataByType(pluginType string) ([]*PluginParentMetadata, error) { |
There was a problem hiding this comment.
pluginType shouldn't be just string , this method should accept the proper type. make same changes in ENT
There was a problem hiding this comment.
The method GetAllPluginMinData() is being called in multiple places internally. And I introduced GetAllPluginMinDataByType(pluginType string) recently for a list API. In theGetAllPluginMinData() we want all types of plugins. In order to reduce the impact area and testing scope, This implementation is being placed
|
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?