Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: err handling for configmap access #5938

Merged
merged 2 commits into from
Oct 3, 2024
Merged

misc: err handling for configmap access #5938

merged 2 commits into from
Oct 3, 2024

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented Oct 1, 2024 •
edited
Loading

Description

Fixes https://github.com/devtron-labs/devops-sprint/issues/983

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@gireesh-naidu gireesh-naidu changed the title fix: err handling for configmap access chore: err handling for configmap access Oct 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
100.0% Duplication on New Code

See analysis details on SonarCloud

@tayalrishabh96 tayalrishabh96 changed the title chore: err handling for configmap access misc: err handling for configmap access Oct 3, 2024
@gireesh-naidu gireesh-naidu merged commit 19ec283 into main Oct 3, 2024
10 of 12 checks passed
@gireesh-naidu gireesh-naidu deleted the telemetry-dashboard-event-panic-fixes branch October 3, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gireesh-naidu @nishant-d