Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: namespace cache delete actions #5887

Merged
merged 7 commits into from
Sep 30, 2024
Merged

fix: namespace cache delete actions #5887

merged 7 commits into from
Sep 30, 2024

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Sep 23, 2024

Description

Fixes #5847

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Sep 23, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13816532 Triggered Generic Private Key 246c8cf vendor/github.com/google/s2a-go/testdata/mds_client_key.pem View secret
10220829 Triggered Generic High Entropy Secret 1f7995e charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret 1f7995e charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret af5f36d devtron-images.txt.source View secret
10220829 Triggered Generic High Entropy Secret 508a70b charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret 508a70b charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 9eabc12 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 9eabc12 charts/devtron/devtron-bom.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

pkg/delete/DeleteService.go Outdated Show resolved Hide resolved
@iamayushm iamayushm changed the title Fix namespace cache fix: namespace cache delete actions Sep 30, 2024
Copy link

sonarcloud bot commented Sep 30, 2024

@iamayushm iamayushm merged commit 3419695 into develop Sep 30, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants