fix: switch ci fixes #5358
Merged
fix: switch ci fixes #5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireesh-naidu
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
subhashish-devtron
approved these changes
Jun 26, 2024
kripanshdevtron
previously approved these changes
Jul 8, 2024
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10220829 | Triggered | Generic High Entropy Secret | 983c890 | charts/devtron/devtron-bom.yaml | View secret |
| 10220829 | Triggered | Generic High Entropy Secret | 983c890 | charts/devtron/values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…from external ci to other ci types
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
kripanshdevtron
approved these changes
Jul 12, 2024
|
Ash-exp
added a commit
that referenced
this pull request
Jul 17, 2024
* feat: 5xx issue for manual cd trigger API * fix: panic handling for case scantool not found * fix: switch ci fixes (#5358) * fix: switch ci fixes * chore: review refactoring * chore: refactoring * fix: add missing validations in switching to external ci * fix: ci pipeline id is not being updated in cd pipeline if switching from external ci to other ci types * fix: update ci pipeline id in all the cd workflows that exists in the given workflow * fix: checkIfNsExistsForEnvIds , empty envIds check fix * fix: ci patch rbac fixes (#5461) * fix: ci patch rbac fixes * fix: rbac optimisation * fix: refactoring --------- Co-authored-by: Asutosh Das <[email protected]> * feat: deployment config migration (#5368) * inital commit - deployment config service * wip: migration changes for devtron apps * changes for helm apps * dev testing fixes * wire fix * bulk get function * wip: bulk logic fixes * wip: bulk fixes * feat: Cd pipeline migration sql and query usage update (#5416) * Added sql * removed unused mthod * wip * wip * wip * wip * wip * wip * QUERY : updated GetOfLatestCdWfrByCdPipelineId * QUERY : GetOfLatestInstalledAppVersionHistoryByInstalledAppVersionId * QUERY : fix GetOfLatestCdWfrByCdPipelineId * QUERY : fix GetOfLatestInstalledAppVersionHistoryByInstalledAppVersionId * QUERY : updated GetLatestTriggersOfHelmPipelinesStuckInNonTerminalStatuses * QUERY : updated GetArgoPipelineByArgoAppName * QUERY : updated GetArgoPipelinesHavingLatestTriggerStuckInNonTerminalStatuses * QUERY : updated GetArgoPipelinesHavingTriggersStuckInLastPossibleNonTerminalTimelines * QUERY : updated GetAppAndEnvDetailsForDeploymentAppTypePipeline * QUERY : updated FindActiveByEnvIdAndDeploymentType * QUERY : updated GetActiveInstalledAppByEnvIdAndDeploymentType * QUERY : updated GetArgoPipelinesHavingTriggersStuckInLastPossibleNonTerminalTimelinesForAppStore * QUERY : updated GetArgoPipelinesHavingLatestTriggerStuckInNonTerminalStatusesForAppStore * QUERY : updated GetInstalledAppByInstalledAppVersionId * QUERY : updated GetInstalledAppByAppIdAndDeploymentType * QUERY : updated GetAppAndEnvDetailsForDeploymentAppTypeInstalledApps * QUERY : updated FindLatestByAppIdAndEnvId * QUERY : updated GetInstalledAppByGitRepoUrl * QUERY : updated FindChartByGitRepoUrl * dev testing fixes * QUERY : UPDATED buildAppListingWhereCondition and FIXED deploymentDetailsByAppIdAndEnvId * function for bulk update config * query changes * remaining query changes * PR review changes and logical fixes * nil pointer fix * fix cd pipeline helm app create * dev testing fixes * updating app stages status check * query active check for deployment config * wip * adding flag for migration and removing bulk code * build fix * wip: modifying get function * handling custom gitops case for app clone * handling app clone with custom gitops for system generated url * fix: wrong call for helm app deployment app type change * fix migration function for helm app * wip: updating dc on template update * fix: replacing migrate with get call * fix: wrong call for helm app * minor fixes * renaming chart path * updating deprecated columns * updating dc.active * updating dc.active * fix redirection * removing chart path * updating migration * conditions in patch object * fix error in flag off-> custom-gitops-> app-clone-> deploy-> flag-on-> migrate * wire fix * audit log fix * migation update * reverted 107 sql newline add --------- Co-authored-by: kartik-579 <[email protected]> Co-authored-by: kartik-579 <[email protected]> * handle nil check (#5497) * doc: Added FAQ no. 28 + GoLang-migrate Link + Code Block Fix (#5502) * Added FAQ no. 28 + GoLang-migrate Link + Code Block Fix * Removed extra spacing at EOF * fix: bitbucket commit race condition for concurrent requests (#5505) * fix: hotfix v0.14.0 fixes (#5500) * fix: patch ci rbac fix (#5498) * handle nil check (#5497) * fix: patch ci rbac fix --------- Co-authored-by: ayu-devtron <[email protected]> * fix: external ci creation fix (#5499) * handle nil check (#5497) * fix: external ci creation fix --------- Co-authored-by: ayu-devtron <[email protected]> * fix for deployment config - auto post cd not working (#5501) * fix: do not create deployment config for switch ci, if pipeline is already created. (#5506) * chore: main sync (#5510) * handle nil check (#5497) * doc: Added FAQ no. 28 + GoLang-migrate Link + Code Block Fix (#5502) * Added FAQ no. 28 + GoLang-migrate Link + Code Block Fix * Removed extra spacing at EOF * fix: bitbucket commit race condition for concurrent requests (#5505) --------- Co-authored-by: ayu-devtron <[email protected]> Co-authored-by: ashokdevtron <[email protected]> Co-authored-by: Asutosh Das <[email protected]> --------- Co-authored-by: ayu-devtron <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: ashokdevtron <[email protected]> Co-authored-by: Asutosh Das <[email protected]> --------- Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: iamayushm <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: ayu-devtron <[email protected]> Co-authored-by: ashokdevtron <[email protected]>
Ash-exp
added a commit
that referenced
this pull request
Jul 18, 2024
* fix: autoscale error handling * minor updates * chore: renaming and logging improved * chore: logging * chore: k8s request adapters * chore: k8s adapter * chore: updated common-lib version * fix: 5xx fixes issues and Panic handling (#5402) * feat: 5xx issue for manual cd trigger API * fix: panic handling for case scantool not found * fix: switch ci fixes (#5358) * fix: switch ci fixes * chore: review refactoring * chore: refactoring * fix: add missing validations in switching to external ci * fix: ci pipeline id is not being updated in cd pipeline if switching from external ci to other ci types * fix: update ci pipeline id in all the cd workflows that exists in the given workflow * fix: checkIfNsExistsForEnvIds , empty envIds check fix * fix: ci patch rbac fixes (#5461) * fix: ci patch rbac fixes * fix: rbac optimisation * fix: refactoring --------- Co-authored-by: Asutosh Das <[email protected]> * feat: deployment config migration (#5368) * inital commit - deployment config service * wip: migration changes for devtron apps * changes for helm apps * dev testing fixes * wire fix * bulk get function * wip: bulk logic fixes * wip: bulk fixes * feat: Cd pipeline migration sql and query usage update (#5416) * Added sql * removed unused mthod * wip * wip * wip * wip * wip * wip * QUERY : updated GetOfLatestCdWfrByCdPipelineId * QUERY : GetOfLatestInstalledAppVersionHistoryByInstalledAppVersionId * QUERY : fix GetOfLatestCdWfrByCdPipelineId * QUERY : fix GetOfLatestInstalledAppVersionHistoryByInstalledAppVersionId * QUERY : updated GetLatestTriggersOfHelmPipelinesStuckInNonTerminalStatuses * QUERY : updated GetArgoPipelineByArgoAppName * QUERY : updated GetArgoPipelinesHavingLatestTriggerStuckInNonTerminalStatuses * QUERY : updated GetArgoPipelinesHavingTriggersStuckInLastPossibleNonTerminalTimelines * QUERY : updated GetAppAndEnvDetailsForDeploymentAppTypePipeline * QUERY : updated FindActiveByEnvIdAndDeploymentType * QUERY : updated GetActiveInstalledAppByEnvIdAndDeploymentType * QUERY : updated GetArgoPipelinesHavingTriggersStuckInLastPossibleNonTerminalTimelinesForAppStore * QUERY : updated GetArgoPipelinesHavingLatestTriggerStuckInNonTerminalStatusesForAppStore * QUERY : updated GetInstalledAppByInstalledAppVersionId * QUERY : updated GetInstalledAppByAppIdAndDeploymentType * QUERY : updated GetAppAndEnvDetailsForDeploymentAppTypeInstalledApps * QUERY : updated FindLatestByAppIdAndEnvId * QUERY : updated GetInstalledAppByGitRepoUrl * QUERY : updated FindChartByGitRepoUrl * dev testing fixes * QUERY : UPDATED buildAppListingWhereCondition and FIXED deploymentDetailsByAppIdAndEnvId * function for bulk update config * query changes * remaining query changes * PR review changes and logical fixes * nil pointer fix * fix cd pipeline helm app create * dev testing fixes * updating app stages status check * query active check for deployment config * wip * adding flag for migration and removing bulk code * build fix * wip: modifying get function * handling custom gitops case for app clone * handling app clone with custom gitops for system generated url * fix: wrong call for helm app deployment app type change * fix migration function for helm app * wip: updating dc on template update * fix: replacing migrate with get call * fix: wrong call for helm app * minor fixes * renaming chart path * updating deprecated columns * updating dc.active * updating dc.active * fix redirection * removing chart path * updating migration * conditions in patch object * fix error in flag off-> custom-gitops-> app-clone-> deploy-> flag-on-> migrate * wire fix * audit log fix * migation update * reverted 107 sql newline add --------- Co-authored-by: kartik-579 <[email protected]> Co-authored-by: kartik-579 <[email protected]> * handle nil check (#5497) * doc: Added FAQ no. 28 + GoLang-migrate Link + Code Block Fix (#5502) * Added FAQ no. 28 + GoLang-migrate Link + Code Block Fix * Removed extra spacing at EOF * fix: bitbucket commit race condition for concurrent requests (#5505) * fix: hotfix v0.14.0 fixes (#5500) * fix: patch ci rbac fix (#5498) * handle nil check (#5497) * fix: patch ci rbac fix --------- Co-authored-by: ayu-devtron <[email protected]> * fix: external ci creation fix (#5499) * handle nil check (#5497) * fix: external ci creation fix --------- Co-authored-by: ayu-devtron <[email protected]> * fix for deployment config - auto post cd not working (#5501) * fix: do not create deployment config for switch ci, if pipeline is already created. (#5506) * chore: main sync (#5510) * handle nil check (#5497) * doc: Added FAQ no. 28 + GoLang-migrate Link + Code Block Fix (#5502) * Added FAQ no. 28 + GoLang-migrate Link + Code Block Fix * Removed extra spacing at EOF * fix: bitbucket commit race condition for concurrent requests (#5505) --------- Co-authored-by: ayu-devtron <[email protected]> Co-authored-by: ashokdevtron <[email protected]> Co-authored-by: Asutosh Das <[email protected]> --------- Co-authored-by: ayu-devtron <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: ashokdevtron <[email protected]> Co-authored-by: Asutosh Das <[email protected]> --------- Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: iamayushm <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: ayu-devtron <[email protected]> Co-authored-by: ashokdevtron <[email protected]> * updated: common-lib version --------- Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: iamayushm <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: kartik-579 <[email protected]> Co-authored-by: ayu-devtron <[email protected]> Co-authored-by: ashokdevtron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2396
Checklist:
Does this PR introduce a user-facing change?