feat: Refrence chart 4.19 added #4939

kamal-devtron · 2024-04-15T07:33:58Z

Description

Fixes #

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

gitguardian · 2024-04-15T07:34:37Z

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10220829	Triggered	Generic High Entropy Secret	`4753231`	devtron-images.txt.source	View secret
10220829	Triggered	Generic High Entropy Secret	`279da7f`	charts/devtron/values.yaml	View secret
10220829	Triggered	Generic High Entropy Secret	`279da7f`	charts/devtron/devtron-bom.yaml	View secret
9257608	Triggered	Base64 AWS keys	`78febd9`	scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json	View secret
2763127	Triggered	Generic High Entropy Secret	`024d62a`	scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`b5ef536`	scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`78febd9`	scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`14d998f`	scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`78febd9`	scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`b5ef536`	scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`14d998f`	scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`024d62a`	scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

sonarcloud · 2024-04-15T07:35:08Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-06-12T12:27:50Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/templates/deployment.yaml

sonarcloud · 2024-08-08T12:24:37Z

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/templates/deployment.yaml

+{{- if $.Values.topologySpreadConstraint }}
+      topologySpreadConstraints: 
+{{ toYaml .Values.topologySpreadConstraint }}  
+{{- end }}    


rupinSec · 2024-10-03T12:58:39Z

updated changes related to envoy readiness, liveness and external secret are reviewed and tested.

sonarcloud · 2024-10-03T13:24:49Z

Quality Gate failed

Failed conditions
1 Security Hotspot
E Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

kamal-devtron added 9 commits March 28, 2024 18:07

rollout ref chart 4.19 added

14d998f

chnages in deploymnet ref chart

6473ccf

chnages in values file

0f8f743

chnage sin ref chart

9ed3902

chnage sin ref chart

3d115eb

changes in ref chart

94a2978

changes in deployment file

7b24c51

changes in values yaml

8fd1f96

refrence chart 4.19 sql script added

33f6e42

kamal-devtron requested review from prakarsh-dt, vikramdevtron, kripanshdevtron, nishant-d and pawan-mehta-dt as code owners April 15, 2024 07:33

changes in deploymnet chart

b3b3c58

kamal-devtron force-pushed the refchart branch from 84f9de1 to b3b3c58 Compare June 17, 2024 11:50

kamal-devtron and others added 6 commits July 30, 2024 12:27

Merge branch 'devtron-labs:main' into refchart

12fdffe

Update .image_descriptor_template.json

7f34eb6

renaming the sql migration number

f17ddfe

changes in refrence chart

f017e0a

changes in refrence chart

b1ac581

chnages in refchart 4.18

c07eed9

github-advanced-security bot found potential problems Aug 5, 2024

View reviewed changes

scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/templates/deployment.yaml Fixed Show fixed Hide fixed

scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/templates/deployment.yaml Fixed Show fixed Hide fixed

kamal-devtron added 3 commits August 6, 2024 15:44

changes in values yaml file

3c574f9

changes in deploymnet.yaml

ee4aa52

added readiness and liveness probes in envoy container

2439b0a

kamal-devtron added 5 commits September 17, 2024 17:01

refrence chart 4-20 added

bc0847a

changes in sql file

fdfdadb

added support for ESO

5fdc7d5

Changes insql script

2906be5

Merge branch 'main' into refchart

caf293d

kamal-devtron force-pushed the refchart branch from 383505b to caf293d Compare September 18, 2024 06:31

changes in deployment yaml

500ea25

kamal-devtron force-pushed the refchart branch from 570ec5a to 500ea25 Compare September 18, 2024 07:58

added support for vpa

8947ea2

kamal-devtron force-pushed the refchart branch from 51368df to 8947ea2 Compare September 18, 2024 10:59

kamal-devtron added 3 commits September 18, 2024 16:53

chnages in structure

28b9462

changes in ref chart and added support for vpa

fc2bba6

changes in values

67f7322

kamal-devtron force-pushed the refchart branch from 9eb4ecd to 67f7322 Compare September 18, 2024 13:14

github-advanced-security bot found potential problems Sep 18, 2024

View reviewed changes

kamal-devtron added 2 commits September 23, 2024 12:36

added 4.19 of reference chart

b5ef536

Merge branch 'main' into refchart

d2a6706

kamal-devtron force-pushed the refchart branch from 8c5d667 to d2a6706 Compare September 23, 2024 07:12

kamal-devtron added 6 commits September 24, 2024 17:11

changes in refrence chart

ec0cd9d

change in apiVersion

d54bf47

changes in VPA

c852dfb

chnages in hpa

6b436df

chnage in yaml

76adf8d

Merge branch 'main' into refchart

279da7f

kamal-devtron force-pushed the refchart branch from c980e20 to 279da7f Compare September 30, 2024 06:12

kamal-devtron added 2 commits October 3, 2024 13:05

added support for external secret template

a13e0e2

changes in deployment yaml

682e955

changes in refrence chart

11ad48c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Refrence chart 4.19 added #4939

feat: Refrence chart 4.19 added #4939

kamal-devtron commented Apr 15, 2024 •

edited by rupinSec

Loading

gitguardian bot commented Apr 15, 2024 •

edited

Loading

sonarcloud bot commented Apr 15, 2024

sonarcloud bot commented Jun 12, 2024

sonarcloud bot commented Aug 8, 2024

rupinSec commented Oct 3, 2024

sonarcloud bot commented Oct 3, 2024

feat: Refrence chart 4.19 added #4939

Are you sure you want to change the base?

feat: Refrence chart 4.19 added #4939

Conversation

kamal-devtron commented Apr 15, 2024 • edited by rupinSec Loading

Description

Checklist:

Does this PR introduce a user-facing change?

gitguardian bot commented Apr 15, 2024 • edited Loading

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

sonarcloud bot commented Apr 15, 2024

Quality Gate passed

sonarcloud bot commented Jun 12, 2024

Quality Gate passed

sonarcloud bot commented Aug 8, 2024

Quality Gate failed

rupinSec commented Oct 3, 2024

sonarcloud bot commented Oct 3, 2024

Quality Gate failed

kamal-devtron commented Apr 15, 2024 •

edited by rupinSec

Loading

gitguardian bot commented Apr 15, 2024 •

edited

Loading