Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ci pipeline material api giving 500 for those application having invalid UTF-8 character in git commits #3930

Closed
2 tasks done
tayalrishabh96 opened this issue Sep 19, 2023 · 0 comments · Fixed by devtron-labs/git-sensor#67
Assignees
Labels
bug Something isn't working pager-duty Bugs / Issues found while on pager duty

Comments

@tayalrishabh96
Copy link
Contributor

tayalrishabh96 commented Sep 19, 2023

📜 Description

It bugs out in case protocol in git sensor is gRPC.
On clicking Select Material in build and deploy page, it will fail if the last few commits has invalid UTF-8 character either in commit msg or description.
error msg : rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8

👟 Reproduction steps

  1. Push any commit with UTF-8 invalid character example : �
  2. Now if you go to build and deploy page and click Select Material, it should fail.

👍 Expected behavior

It should have handled the invalid UTF-8 character.

👎 Actual Behavior

It fails with error : rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8

☸ Kubernetes version

NA

Cloud provider

NA

🌍 Browser

Chrome

🧱 Your Environment

NA

✅ Proposed Solution

NA

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

AB#5599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pager-duty Bugs / Issues found while on pager duty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants