feat: Generalize user preferences as per resource kind #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhishekA1509
requested changes
Jun 24, 2025
| @@ -76,30 +88,33 @@ export interface UserPreferencesType { | |||
| export interface UpdatedUserPreferencesType extends UserPreferencesType, Pick<ThemeConfigType, 'appTheme'> {} | |||
|
|
|||
| export interface UseUserPreferencesProps { | |||
| userPreferenceResourceKind?: ResourceKindType | |||
There was a problem hiding this comment.
PreferredResourceKindType, pls check across
| @@ -34,6 +33,17 @@ import { | |||
| } from './types' | |||
| import { getUserPreferenceResourcesMetadata } from './utils' | |||
|
|
|||
| export const getParsedResourcesMap = (resources: GetUserPreferencesParsedDTO['resources']) => { | |||
| export const USER_PREFERENCES_ATTRIBUTE_KEY = 'userPreferences' | ||
|
|
||
| export const PreferredResourceKinds: PreferredResourceKindType[] = [ |
There was a problem hiding this comment.
Pls move to UPPER_CASE and can we make object since that will be type safe if new type is added
| const parsedResourcesMap: UserPreferencesType['resources'] = {} | ||
|
|
||
| PreferredResourceKinds.forEach((resourceKind) => { | ||
| parsedResourcesMap[resourceKind] = resources?.[resourceKind] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context switcher implementation for
Type of change
Checklist