feat: host url cicd event in pre post ci and cd #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13816532 | Triggered | Generic Private Key | f6e2f2a | vendor/github.com/google/s2a-go/testdata/mds_client_key.pem | View secret |
| 13816533 | Triggered | Generic Private Key | f6e2f2a | vendor/github.com/google/s2a-go/testdata/mds_server_key.pem | View secret |
| 13816534 | Triggered | Generic Private Key | f6e2f2a | vendor/github.com/google/s2a-go/testdata/self_signed_key.pem | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
gireesh-naidu
approved these changes
Sep 23, 2024
vikramdevtron
added a commit
that referenced
this pull request
Oct 3, 2024
* fix: delete dangling buildkit deployments leveraging owner-reference (#178) * fix: delete dangling buildkit deployments leveraging owner-reference * vendor update * update k8s vendor files * update vendor * fix: use constants from common lib * chore: refactor buildx nodes create logic * chore: common lib version bump (#183) * common lib version bump * semantic * feat: host url cicd event in pre post ci and cd (#185) * added field baseUrl * added host url field * remove job check * semantic * fix: sync with common-lib changes This PR was created by multi-gitter to sync common-lib changes across multiple repositories. --------- Co-authored-by: iamayushm <[email protected]> Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: Prakash <[email protected]> Co-authored-by: Rajeev Ranjan <[email protected]> Co-authored-by: Ash-exp <[email protected]> Co-authored-by: prakhar katiyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devtron-labs/devtron#5598