Remove friends function #1083
Open
Remove friends function #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-trann
reviewed
Oct 22, 2025
Contributor
mark-trann
left a comment
mark-trann
left a comment
There was a problem hiding this comment.
good code changes! A bit of a ui mismatch and gave some suggestions on how to make it closer to the mock.
before:
after:
Contributor
There was a problem hiding this comment.
These changes are from another PR that was taken into server-rewrite. Pls rebase properly!
Contributor
|
@sunnyyuqingchen you should implement the profile picture into the RemoveFriend modal component too - use the |
sunnyyuqingchen
force-pushed
the
remove-friends-function
branch
from
e1fa6fe to
60e8d75
Compare
* make server listen on 0.0.0.0 to accept connections from any external devices * Added pending friend invites badge with hardcoded invite values. Changed friends icon to a group icon instead. * Reverted back to localhost binding * Swapped to use red theme colour instead * Added pr review fix
Co-authored-by: Mark Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 🧾
Remove friends UI minus displaying pfp.