-
Notifications
You must be signed in to change notification settings - Fork 8
Undo/Clear Timetable Buttons: Move Position to Make Room for Dropdown UI (#1074) #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
mark-trann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just some nitpicks
| import TermSelect from './TermSelect'; | ||
| const ControlsBar = styled(Box)` | ||
| display: flex; | ||
| align-items: flex-end; // Align all controls to the bottom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment 🪓
| min-width: 140px; | ||
| display: flex; | ||
| align-items: flex-start; | ||
| margin-bottom: 0; // Remove any margin that could misalign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here 🪓
Description 🧾
Testing
Manually test in browser:
Checklist
feature: for application feature improvement or new featuresbug: fixing something that previously wasn't workingdev: development-side related changesdocker: updates to the Docker codesetup: changes to the setup/infrastructure of the codebasetest: updates to internal testingIssue: #1074