Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error message for unknown macOS version #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: improve error message for unknown macOS version #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/engines/javascriptcore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,16 @@ async function getVersionFromBuilder(builder) {
}

async function getMacBuilder() {
switch (await macName()) {
const name = await macName();
switch (name) {
case 'ventura':
return 706;
case 'monterey':
return 368;
case 'sonoma':
return 938;
default:
throw new Error(`Unknown macOS release: ${macName()}`);
throw new Error(`Unknown macOS release: ${name}. If it's a new version, consider making a pull request to https://github.com/devsnek/esvu.`);
}
}

Expand Down