Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename boringssl symbols to avoid name collision with OpenSSL #26

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

aliclark
Copy link

@aliclark aliclark commented Aug 3, 2016

Hi,

Thanks for sharing libquic :)

Would you be interested in a change to rename BoringSSL's symbols to not collide with OpenSSL?

The following statement provides some justification, since at current programs using libquic would be forced to switch from OpenSSL to BoringSSL, which probably isn't desired.

"Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it."
https://boringssl.googlesource.com/boringssl/

A few things that could be improved:

  • Use git mv on include/openssl instead of mv
  • Better naming/location of files
  • The rename of the include directory isn't strictly necessary for building libquic, and is more of a failsafe in-case anyone put the include dir on a global search path. Should probably undo that one.

Thanks,
Ali

@aliclark
Copy link
Author

aliclark commented Aug 3, 2016

Also, please note I haven't fixed up all .pl files, just those that seemed relevant to my use-case, so a bit of extra work may be needed to finish those. My platform is x86-64 - it's possible other platforms still need extra work.

It probably makes sense to write another program to verify that all global symbols have in fact been renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant