Rename boringssl symbols to avoid name collision with OpenSSL #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for sharing libquic :)
Would you be interested in a change to rename BoringSSL's symbols to not collide with OpenSSL?
The following statement provides some justification, since at current programs using libquic would be forced to switch from OpenSSL to BoringSSL, which probably isn't desired.
"Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it."
https://boringssl.googlesource.com/boringssl/
A few things that could be improved:
git mv
on include/openssl instead ofmv
Thanks,
Ali