-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add showNews method #648
Conversation
🦋 Changeset detectedLatest commit: 4cbd43a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is great, big thanks! I've created a news item (33910172) and tested it but at the moment it doesn't work. I think this has to do with the fact that this feature is still in beta |
Hi! really looking forward to this feature. I wired it up it with
for now and it worked. Hoping to see it in P.S I had to figure out what the news item id is. The one you're looking for can be found if you click into a news item, and in its url you'll find
where |
reverts pnpm version
9607c09
to
8eebbed
Compare
Yep, unfortunately it looks like I'll need a different ID to make the example work and not just show a white screen 🤔 |
This is interesting, thanks. Unfortunately, I can't create a news item for the playground namespace. News is at the moment not part of the Intercom development namespace |
Big thanks. Unfortunately, I can't create a news item for the playground namespace. News is at the moment not part of the Intercom development namespace |
@devrnt I've tried countless of time building this project in a docker container running Do you have any idea on what I should take a look at to get everything to work? I'm a bit lost 🤔 |
802f272
to
8eebbed
Compare
The pipeline is working again. Still thinking about what to do with the news id in the examples |
Later than expected but I decided to merge this PR even without a working example. I still can't create a news item for the playground/demo namespace |
Big thanks! |
Intercom has recently(?) added the
showNews
feature and I figured it might be worth it to map it 😄 https://developers.intercom.com/installing-intercom/docs/intercom-javascript#intercomshownews-newsitemidI would have also added an e2e test for the feature but without having an actual
news
on the intercom instance it just didn't make much sense.If you could please create a
news
on Intercom and provide thenewsId
I'll gladly write an E2E for it!