Allow arguments and options to be passed to child process spawn #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow arguments to be passed when spawning child process
…or an instance of PowerJS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not allow specifying any arguments or options to pass to
child_process.spawnwhen creating a new instance ofPowerJS. This pull request modifies the constructor ofPowerJSto accept optionalshellArgsandoptionsin the object of options passed to the constructor. These are then passed to theargsandoptionsarguments ofchild_process.spawn, respectively. IfshellArgsand/oroptionsis not passed to the constructor ofPowerJS, then it is ignored, as per the current implementation.Uses include passing flags to the initial invocation of PowerShell (available flags) and passing options that affect the child process itself, such as the current working directory or environment variables for the child process.
Closes #8 since
-NoProfilecan be one of the arguments passed withshellArgs.